HYPERFLEET-879 - feat: add Go tooling pre-commit hooks via Make targets#3
Open
rafabene wants to merge 1 commit intoopenshift-hyperfleet:mainfrom
Open
Conversation
rafabene
force-pushed
the
HYPERFLEET-879-bingo-aware-go-hooks
branch
from
65296e6 to
b003bba
Compare
rafabene
force-pushed
the
HYPERFLEET-879-bingo-aware-go-hooks
branch
from
b003bba to
143aa0c
Compare
ciaranRoche
reviewed
Apr 15, 2026
rafabene
force-pushed
the
HYPERFLEET-879-bingo-aware-go-hooks
branch
from
143aa0c to
4856bba
Compare
Use language: system to delegate golangci-lint, gofmt, and go-vet hooks to the consuming repo's existing Make targets, leveraging bingo-managed tool resolution already in place. Only commitlint remains as language: golang since it has custom validation logic.
rafabene
force-pushed
the
HYPERFLEET-879-bingo-aware-go-hooks
branch
from
4856bba to
2e9e399
Compare
rafabene
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golangci-lint,gofmt,go-vetlanguage: systemand delegate to the consuming repo's existing Make targets (make lint,make gofmt,make go-vet), leveraging bingo-managed tool resolution already in placecommitlintuseslanguage: golangas it has custom validation logicDepends on: #2
Acceptance Criteria
language: systemTest Plan
go test -race ./...passesgo vet ./...passesgofmt -l .clean on changed files